AriasCreations/AVsitter
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Check permissions before starting/stopping overlay animations

Browse source 
This partially solves a race condition when avatars revoke animation permissions on stand, but the message needs to travel through several scripts and, in case of extreme lag conditions, can attempt to stop animations after the revocation arrives, resulting in an error.

It still suffers a TOCTTOU race, as demonstrated by the reporter. That race is probably unsolvable.

Fixes #119. Big thanks to @ohhmye for reporting and investigating this bug.
This commit is contained in:
Sei Lisa 2020-01-24 00:06:29 +01:00 committed by Sei-Lisa
parent af4de9c6bf
commit f8296a0a38
1 changed files with 7 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
AVsitter2/[AV]sitA.lsl
View file

@ -750,15 +750,14 @@ default
}
if (id == MY_SITTER)
{
if (num == 90001) // 90001=start an overlay animation
if ((num == 90001 || num == 90002) // 90001=start an overlay animation
// 90002=stop an overlay animation
&& (PERMISSION_TRIGGER_ANIMATION & llGetPermissions()) != 0)
{
llStartAnimation(msg);
return;
}
if (num == 90002) // 90002=stop an overlay animation
{
llStopAnimation(msg);
return;
if (num == 90001)
llStartAnimation(msg);
else
llStopAnimation(msg);
}
data = llParseStringKeepNulls(msg, ["|"], data);
if (num == 90101) // 90101=menu option chosen