AriasCreations/LSL-PyOptimizer
3
0
Fork 0
mirror of https://github.com/Sei-Lisa/LSL-PyOptimizer synced 2025-07-01 23:58:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Reorganize the checks, and eliminate the fn call check

Browse source 
After more thought, we believe that transforming llDumpList2String into a sum of strings is a gain even if there is a list constructor containing function calls as first parameter. The rationale is explained in the comment.
This commit is contained in:
Sei Lisa 2018-11-22 23:31:50 +01:00
parent 0a6155bb13
commit a052bf499c
1 changed files with 44 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

71
lslopt/lslfuncopt.py
View file

@ -194,34 +194,51 @@ def OptimizeFunc(self, parent, index):
if list_len > threshold: if list_len > threshold:
return return
for i in range(list_len): elems = [self.GetListNodeElement(child[0], i)
# Can't be optimized if the list has any function calls in any for i in range(list_len)]
# of the elements, or if they can't be extracted.
# If an element is a list, we can't optimize it either, as that
# will produce a side effect (namely an error).
val = self.GetListNodeElement(child[0], i)
if (val is False or type(val) == nr and (val.t == 'list'
or not FnFree(self, val))
):
# With our simple analysis, we can't guarantee that
# whatever the content is, there are no functions.
break
else: # Don't optimize if an element can't be extracted or is a list
# Optimize to a sum of strings, right-to-left if any(i is False or type(i) == nr and i.t == 'list'
i = list_len - 1 for i in elems):
newnode = CastDL2S(self, child[0], i) return
while i > 0:
i -= 1 # We reorder list constructors as right-to-left sums. When an
newnode = nr(nt='+', t='string', SEF=True, # element contains function calls, it will generate a savepoint,
ch=[CastDL2S(self, child[0], i), # but with that strategy, the maximum extra stack size at the time
nr(nt='+', t='string', SEF=True, # of each savepoint is 1.
ch=[self.Cast(child[1], 'string'), newnode] # If the first element has a function call, we may end up causing
) # more memory usage, because in a list constructor, the first
]) # element has no stack to save; however, if any elements past the
parent[index] = newnode # third have function calls at the same time, the memory we add
# Re-fold # will be compensated by the memory we save, because the 3rd
self.FoldTree(parent, index) # element has 2 elements in the stack, therefore reducing it to 1
# is a save; similarly, any elements past the 3rd containing
# function calls cause bigger and bigger saves.
# Since we're also eliminating the llDumpList2String function call,
# that may count for the extra stack element added. Therefore, we
# disable this condition and optimize unconditionally.
#if (child[0].nt in ('LIST', 'CONST') and list_len >= 3
# and type(elems[0]) == nr and not FnFree(self, elems[0])
# and all(type(i) != nr or FnFree(self, i) for i in elems[2:])
# ):
# return
# Optimize to a sum of strings, right-to-left to save stack.
i = list_len - 1
newnode = CastDL2S(self, child[0], i)
while i > 0:
i -= 1
newnode = nr(nt='+', t='string', SEF=True,
ch=[CastDL2S(self, child[0], i),
nr(nt='+', t='string', SEF=True,
ch=[self.Cast(child[1], 'string'), newnode]
)
])
parent[index] = newnode
# Re-fold
self.FoldTree(parent, index)
return return
if (name in ('llList2String', 'llList2Key', 'llList2Integer', if (name in ('llList2String', 'llList2Key', 'llList2Integer',