AriasCreations/LSL-PyOptimizer
3
0
Fork 0
mirror of https://github.com/Sei-Lisa/LSL-PyOptimizer synced 2024-11-21 06:15:56 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix llDumpList2String disaster with string addition

Browse source 
The node containing the separator was not being copied; if it was modified by a later optimization step, the modification propagated to all previous nodes that contained it, causing incorrect results.

Many thanks to @KrsityKu for reporting and providing a repro.

Fixes #23.
This commit is contained in:
Sei Lisa 2023-02-26 09:41:46 +01:00
parent d6162dfcf2
commit d58217ad96
4 changed files with 24 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lslopt/lslfuncopt.py
View file

@ -305,7 +305,7 @@ def OptimizeFunc(self, parent, index):
newnode = nr(nt='+', t='string', SEF=True,
ch=[CastDL2S(self, child[0], i),
nr(nt='+', t='string', SEF=True,
ch=[self.Cast(child[1], 'string'), newnode]
ch=[self.Cast(child[1], 'string').copy(), newnode]
)
])
parent[index] = newnode

11
unit_tests/regression.suite/issue-23.lsl Normal file
View file

@ -0,0 +1,11 @@
default
{
state_entry()
{
string tmp0 = llGetScriptName();
list tmp1 = [llGetOwner(), llGetOwner()];
list tmp2 = [llGetScriptName(), llGetScriptName()];
string encoded = llDumpList2String([tmp0, llList2CSV(tmp1), "Hello", 123, llList2CSV(tmp2)], "|");
llOwnerSay(encoded);
}
}

11
unit_tests/regression.suite/issue-23.out Normal file
View file

@ -0,0 +1,11 @@
default
{
state_entry()
{
string tmp0 = llGetScriptName();
list tmp1 = (list)llGetOwner() + llGetOwner();
list tmp2 = (list)llGetScriptName() + llGetScriptName();
string encoded = tmp0 + ("|" + (llList2CSV(tmp1) + ("|Hello|123|" + llList2CSV(tmp2))));
llOwnerSay(encoded);
}
}

1
unit_tests/regression.suite/issue-23.run Normal file
View file

@ -0,0 +1 @@
./main.py -O addstrings -