AriasCreations/LSL-PyOptimizer
3
0
Fork 0
mirror of https://github.com/Sei-Lisa/LSL-PyOptimizer synced 2025-07-01 23:58:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix parenthesization of unary minus

Browse source 
The algorithm for adding parentheses around unary operators was not working properly. It converted a * (-b) * c into a * -b * c, which LSL handles as a * -(b * c).

Fix and add test cases for that. One of the test cases shows an example where the difference matters: 0 * (-1e20) * 1e20 should result in 0.0, but if wrongly parenthesized, it gives NaN, because 1e20*1e20 gives infinity due to float overflow, and minus infinity times 0 is indeterminate.

The addition of parentheses has been improved, but it still does not eliminate every redundant parenthesis.

Also fix the horrendous typo of using "operands" where it should be "operators".
This commit is contained in:
Sei Lisa 2019-05-04 23:07:45 +02:00
parent 9d540798b4
commit ec509b3840
6 changed files with 78 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

6
unit_tests/coverage.suite/lslparse-2.out
View file

@ -15,9 +15,9 @@ default
list L;
f += (float)i;
L += (list)((integer)((float)i));
i = (~(integer)-2) * 3;
i = (~(integer)-2.) * 3;
i = (~(integer)(-i)) * 3;
i = ~(integer)-2 * 3;
i = ~(integer)-2. * 3;
i = ~(integer)(-i) * 3;
"" + (string)((key)"");
(string)((key)"") + "";
@J;