MinecraftMods/BCLib
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Use ResourceKey as an alternative to Holders

Browse source
This commit is contained in:
Frank 2022-12-03 13:25:59 +01:00
parent 0204c5fb73
commit 5c7ac126ed
2 changed files with 44 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/main/java/org/betterx/bclib/api/v2/levelgen/biomes/BCLBiome.java
View file

@ -224,6 +224,21 @@ public class BCLBiome extends BCLBiomeSettings implements BiomeData {
}
}
/**
* Create a new Biome
*
* @param biomeID {@link ResourceLocation} of the wrapped Biome
* @param defaults The Settings for this Biome or null if you want to apply the defaults
*/
protected BCLBiome(ResourceLocation biomeID, BCLBiomeSettings defaults) {
this.biomeID = biomeID;
this.biomeKey = ResourceKey.create(Registries.BIOME, biomeID);
if (defaults != null) {
defaults.applyWithDefaults(this);
}
}
/**
* Changes the intended Type for this Biome
*

38
src/main/java/org/betterx/bclib/api/v2/levelgen/biomes/BCLBiomeBuilder.java
View file

@ -606,6 +606,19 @@ public class BCLBiomeBuilder {
return this;
}
/**
* Adds new feature to the biome.
*
* @param decoration {@link Decoration} feature step.
* @param feature {@link PlacedFeature}.
* @return same {@link BCLBiomeBuilder} instance.
*/
public BCLBiomeBuilder feature(Decoration decoration, ResourceKey<PlacedFeature> feature) {
featureSupliers.add(gen -> gen.addFeature(decoration, feature));
return this;
}
/**
* Adds vanilla Mushrooms.
*
@ -674,17 +687,24 @@ public class BCLBiomeBuilder {
* @param carver {@link ConfiguredWorldCarver} to add.
* @return same {@link BCLBiomeBuilder} instance.
*/
public BCLBiomeBuilder carver(GenerationStep.Carving step, Holder<? extends ConfiguredWorldCarver<?>> carver) {
final ResourceLocation immutableID = biomeID;
var oKey = carver.unwrapKey();
public BCLBiomeBuilder carver(GenerationStep.Carving step, Holder<ConfiguredWorldCarver<?>> carver) {
final Optional<ResourceKey<ConfiguredWorldCarver<?>>> oKey = carver.unwrapKey();
if (oKey.isPresent()) {
BiomeModifications.addCarver(
ctx -> ctx.getBiomeKey().location().equals(immutableID),
step,
(ResourceKey<ConfiguredWorldCarver<?>>) oKey.get()
);
return carver(step, oKey.get());
}
//carvers.add(new Pair<>(step, carver));
return this;
}
public BCLBiomeBuilder carver(
GenerationStep.Carving step,
ResourceKey<ConfiguredWorldCarver<?>> carverKey
) {
BiomeModifications.addCarver(
ctx -> ctx.getBiomeKey().location().equals(biomeID),
step,
carverKey
);
return this;
}