diff --git a/src/main/java/org/betterx/bclib/api/v2/generator/BiomePicker.java b/src/main/java/org/betterx/bclib/api/v2/generator/BiomePicker.java index 56d9f33c..4f18fca5 100644 --- a/src/main/java/org/betterx/bclib/api/v2/generator/BiomePicker.java +++ b/src/main/java/org/betterx/bclib/api/v2/generator/BiomePicker.java @@ -117,11 +117,10 @@ public class BiomePicker { all.put(bclBiome, this); this.bclBiome = bclBiome; - //TODO: 1.19.3 is it ok to build the key? this.key = ResourceKey.create( Registries.BIOME, bclBiome.getID() - );//biomeRegistry.getResourceKey(biomeRegistry.get(bclBiome.getID())).orElse(null); + ); this.biome = (key != null && biomeRegistry != null) ? biomeRegistry.getOrThrow(key) : null; this.isValid = key != null && biome != null && biome.isBound() && biomeRegistry.get(key).isPresent(); bclBiome.forEachSubBiome((b, w) -> { diff --git a/src/main/java/org/betterx/bclib/api/v2/levelgen/biomes/BiomeAPI.java b/src/main/java/org/betterx/bclib/api/v2/levelgen/biomes/BiomeAPI.java index 7c8d0665..7bca7b9c 100644 --- a/src/main/java/org/betterx/bclib/api/v2/levelgen/biomes/BiomeAPI.java +++ b/src/main/java/org/betterx/bclib/api/v2/levelgen/biomes/BiomeAPI.java @@ -237,7 +237,6 @@ public class BiomeAPI { HolderGetter registryOrNull = bootstrapContext.lookup(Registries.BIOME); if (registryOrNull != null && bclbiome._hasBiomeToRegister() - //TODO: 1.19.3 this was a ResourceLocation lookup, is this a valid test? && registryOrNull.get(bclbiome.getBiomeKey()).map(v -> v.isBound()).orElse(false) == false) { bootstrapContext.register(bclbiome.getBiomeKey(), bclbiome._getBiomeToRegister()); diff --git a/src/main/java/org/betterx/bclib/api/v3/levelgen/features/BCLFeatureBuilder.java b/src/main/java/org/betterx/bclib/api/v3/levelgen/features/BCLFeatureBuilder.java index d7d9cb67..c94c0ea4 100644 --- a/src/main/java/org/betterx/bclib/api/v3/levelgen/features/BCLFeatureBuilder.java +++ b/src/main/java/org/betterx/bclib/api/v3/levelgen/features/BCLFeatureBuilder.java @@ -938,33 +938,6 @@ public abstract class BCLFeatureBuilder, FC extends Featur public SimpleBlockConfiguration createConfiguration() { return new SimpleBlockConfiguration(new WeightedStateProvider(stateBuilder.build())); } - - //TODO: Remove in the next Minor Update. This method is just for backward compatibility. - - @Override - public WeightedBlock add(Block block, int weight) { - return super.add(block, weight); - } - - //TODO: Remove in the next Minor Update. This method is just for backward compatibility. - @Override - public WeightedBlock add(BlockState state, int weight) { - return super.add(state, weight); - } - - //TODO: Remove in the next Minor Update. This method is just for backward compatibility. - - @Override - public WeightedBlock addAllStates(Block block, int weight) { - return super.addAllStates(block, weight); - } - - //TODO: Remove in the next Minor Update. This method is just for backward compatibility. - - @Override - public WeightedBlock addAllStatesFor(IntegerProperty prop, Block block, int weight) { - return super.addAllStatesFor(prop, block, weight); - } } diff --git a/src/main/java/org/betterx/bclib/mixin/common/NoiseGeneratorSettingsMixin.java b/src/main/java/org/betterx/bclib/mixin/common/NoiseGeneratorSettingsMixin.java deleted file mode 100644 index 07834a8c..00000000 --- a/src/main/java/org/betterx/bclib/mixin/common/NoiseGeneratorSettingsMixin.java +++ /dev/null @@ -1,22 +0,0 @@ -package org.betterx.bclib.mixin.common; - -import net.minecraft.world.level.levelgen.NoiseGeneratorSettings; - -import org.spongepowered.asm.mixin.Mixin; - -@Mixin(NoiseGeneratorSettings.class) -public abstract class NoiseGeneratorSettingsMixin { - - - ; -//TODO:1.19.3 Replaced by Datagen pack file in NoiseDatagen -// @Inject(method = "bootstrap", at = @At("HEAD")) -// private static void bcl_addNoiseGenerators( -// BootstapContext bootstapContext, CallbackInfo ci -// ) { -// bootstapContext.register( -// BCLChunkGenerator.AMPLIFIED_NETHER, -// BCLChunkGenerator.amplifiedNether(bootstapContext) -// ); -// } -}