1.12: Factory Hopper. Recipe json file tree structured. Conditional recipe constant fixed. Waste Incinerator shifting improved.

1.12/src/main/java/wile/engineersdecor/ModContent.java

@@ -473,6 +473,7 @@ public class ModContent
     TREATED_WOOD_CRAFTING_TABLE, TREATED_WOOD_CRAFTING_TABLE_TEI,
     SMALL_LAB_FURNACE, SMALL_LAB_FURNACE_TEI,
     SMALL_ELECTRICAL_FURNACE, SMALL_ELECTRICAL_FURNACE_TEI,
+    FACTORY_HOPPER,FACTORY_HOPPER_TEI,
     FACTORY_DROPPER, FACTORY_DROPPER_TEI,
     SMALL_WASTE_INCINERATOR, WASTE_INCINERATOR_TEI,
     STRAIGHT_CHECK_VALVE, STRAIGHT_REDSTONE_VALVE, STRAIGHT_REDSTONE_ANALOG_VALVE, STRAIGHT_PIPE_VALVE_TEI,
@@ -532,7 +533,6 @@ public class ModContent
     SIGN_MINDSTEP,
     PANZERGLASS_SLAB,                         // @todo: check if another class is needed due to is_side_visible
     TREATED_WOOD_FLOOR,                       // @todo: check if textures need improvement
-    FACTORY_HOPPER,FACTORY_HOPPER_TEI,
     TEST_BLOCK,TEST_BLOCK_TEI
   };
 

1.12/src/main/java/wile/engineersdecor/blocks/BlockDecorHopper.java

@@ -798,7 +798,7 @@ public class BlockDecorHopper extends BlockDecorDirected
         collection_volume = (new AxisAlignedBB(pos.up())).grow(0.1+collection_range_, 0.6, 0.1+collection_range_);
       } else {
         rpos = pos.add(0.5, -1.5,0.5);
-        collection_volume = (new AxisAlignedBB(pos.down())).grow(0.1+collection_range_, 0.7, 0.1+collection_range_);
+        collection_volume = (new AxisAlignedBB(pos.down(2))).grow(0.1+collection_range_, 1, 0.1+collection_range_);
       }
       final List<EntityItem> items = world.getEntitiesWithinAABB(EntityItem.class, collection_volume);
       if(items.size() <= 0) return false;

1.12/src/main/resources/assets/engineersdecor/recipes/dependent/straight_pipe_valve_redstone_recipe.json

@@ -3,15 +3,15 @@
     {
       "type": "engineersdecor:grc",
       "result": "engineersdecor:straight_pipe_valve_redstone",
-      "required": ["engineersdecor:straight_pipe_valve"]
+      "required": ["engineersdecor:straight_pipe_valve", "immersiveengineering:connector"]
     }
   ],
   "type": "minecraft:crafting_shapeless",
   "ingredients": [
-    { "item": "engineersdecor:straight_pipe_valve" },
+    { "item": "engineersdecor:straight_pipe_valve", "data": 0 },
     { "item": "#anyDirectedRedstoneConnector" }
   ],
   "result": {
-    "item": "engineersdecor:straight_pipe_valve_redstone"
+    "item": "engineersdecor:straight_pipe_valve_redstone", "data": 0
   }
 }