fix: circular dependency and Java 8 feature use

.gitignore

@@ -1,7 +1,6 @@
 # Directories
 .gradle/
 .settings/
-.vscode
 bin/
 build/
 dist/

.vscode/.gitignore

@@ -0,0 +1 @@
+settings.json

.vscode/launch.json

@@ -1,7 +1,4 @@
 {
-    // Use IntelliSense to learn about possible attributes.
-    // Hover to view descriptions of existing attributes.
-    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
     "version": "0.2.0",
     "configurations": [
         {

.vscode/settings.json

@@ -1,4 +0,0 @@
-{
-    "java.configuration.updateBuildConfiguration": "automatic",
-    "java.home": "C:\\Program Files\\Amazon Corretto\\jdk11.0.3_7"
-}

src/main/java/com/atlauncher/App.java

@@ -276,24 +276,18 @@ public class App {
             }
         }
 
-        if (Files.notExists(FileSystem.CONFIGS)) {
-            try {
-                if (Files.list(FileSystem.CONFIGS.getParent()).count() > 1) {
-                    String content = HTMLUtils.centerParagraph("I've detected that you may "
-                            + "not have installed this in the right location.<br/><br/>The exe or jar file should "
-                            + "be placed in it's own folder with nothing else in it.<br/><br/>Are you 100% sure "
-                            + "that's what you've done?");
+        if (Files.notExists(FileSystem.CONFIGS) && FileSystem.CONFIGS.getParent().toFile().listFiles().length > 1) {
+            String content = HTMLUtils.centerParagraph("I've detected that you may "
+                    + "not have installed this in the right location.<br/><br/>The exe or jar file should "
+                    + "be placed in it's own folder with nothing else in it.<br/><br/>Are you 100% sure "
+                    + "that's what you've done?");
 
-                    int returnOption = DialogManager.optionDialog().setParent(null).setTitle("Warning")
-                            .setContent(content).addOption("Yes It's Fine", true)
-                            .addOption("Whoops. I'll Change That Now").setType(DialogManager.ERROR).show();
+            int returnOption = DialogManager.optionDialog().setParent(null).setTitle("Warning")
+                    .setContent(content).addOption("Yes It's Fine", true)
+                    .addOption("Whoops. I'll Change That Now").setType(DialogManager.ERROR).show();
 
-                    if (returnOption != 0) {
-                        System.exit(0);
-                    }
-                }
-            } catch (IOException e) {
-                // ignored
+            if (returnOption != 0) {
+                System.exit(0);
             }
         }
 

src/main/java/com/atlauncher/data/Instance.java

@@ -214,7 +214,6 @@ public class Instance implements Cloneable {
      * Minecraft.
      *
      * @see com.atlauncher.mclauncher.MCLauncher
-     * @see com.atlauncher.mclauncher.LegacyMCLauncher
      */
     private boolean newLaunchMethod;
 

src/main/java/com/atlauncher/data/Settings.java

@@ -1197,7 +1197,7 @@ public class Settings {
                 if (isUsingCustomJavaPath()) {
                     this.javaPath = properties.getProperty("javapath", OS.getJavaHome());
                 } else {
-                    this.javaPath = Java.getActualJavaVersion();
+                    this.javaPath = OS.getJavaHome();
                 }
             }
 

src/main/java/com/atlauncher/utils/Java.java

@@ -77,7 +77,7 @@ public class Java {
 
             if (version.equals("Unknown")) {
                 LogManager.warn("Cannot get Java version from the output of \""
-                        + String.join(" ", processBuilder.command()) + " -version\"");
+                        + getPathToSystemJavaExecutable() + " -version\"");
             }
 
             return version;